Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fastapi-mvc project template into generators submodule #98

Merged
merged 10 commits into from
May 7, 2022

Conversation

rszamszur
Copy link
Member

@rszamszur rszamszur commented May 6, 2022

Checklist:

  • Added tests for changed code where applicable.
  • Documentation reflects the changes where applicable.
  • Updated the CHANGELOG.md file with your changes.
  • My PR is ready to review.

Resolves: #77

Description of the changes being introduced by the pull request:

@rszamszur rszamszur added the refactor Related to major code refactoring/reorganisation label May 6, 2022
@rszamszur rszamszur added this to the 0.12.0 milestone May 6, 2022
@rszamszur rszamszur self-assigned this May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #98 (8fb2ab3) into master (54fc259) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files          39       39              
  Lines         797      794       -3     
==========================================
- Hits          794      791       -3     
  Misses          3        3              
Impacted Files Coverage Δ
fastapi_mvc/commands/base.py 100.00% <ø> (ø)
fastapi_mvc/commands/invoker.py 100.00% <ø> (ø)
fastapi_mvc/commands/run_shell.py 100.00% <ø> (ø)
fastapi_mvc/generators/controller/__init__.py 100.00% <ø> (ø)
fastapi_mvc/generators/generator/__init__.py 100.00% <ø> (ø)
...r_name}}/{{cookiecutter.package_name}}/app/asgi.py 100.00% <ø> (ø)
...ter.package_name}}/app/controllers/api/v1/ready.py 100.00% <ø> (ø)
...cookiecutter.package_name}}/app/exceptions/http.py 100.00% <ø> (ø)
.../{{cookiecutter.package_name}}/app/models/ready.py 100.00% <ø> (ø)
...cookiecutter.package_name}}/app/models/response.py 100.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09e194...8fb2ab3. Read the comment docs.

@rszamszur rszamszur marked this pull request as ready for review May 7, 2022 15:45
@rszamszur rszamszur merged commit a6da4dd into master May 7, 2022
@rszamszur rszamszur deleted the refactor_project_generator branch May 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Related to major code refactoring/reorganisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor fastapi-mvc project template into generators submodule
2 participants