Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documtation #640

Merged
merged 2 commits into from Jun 8, 2021
Merged

Conversation

soulee-dev
Copy link
Contributor

Hello! Since I committed in #344 (comment) , It's been almost 1yrs! I've been always grateful for your art of work!

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #640 (6c76b54) into master (c5f0eb2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1005      1005           
=========================================
  Hits          1005      1005           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f0eb2...6c76b54. Read the comment docs.

@soulee-dev
Copy link
Contributor Author

It's simple fix typo

jwt_authentication = JWTAuthentication(secret=SECRET, lifetime_seconds=3600))

there is doubled round bracket! so I edited!

@frankie567
Copy link
Member

Indeed! Time flies my friend 😄

Thank you for the typo fix, much appreciated 👍

@frankie567
Copy link
Member

@allcontributors add @lill74 for docs

@allcontributors
Copy link
Contributor

@frankie567

I've put up a pull request to add @lill74! 🎉

@frankie567 frankie567 merged commit 22384f6 into fastapi-users:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants