Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate setup.py file #896

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

mekanix
Copy link
Contributor

@mekanix mekanix commented Jan 24, 2022

As Python integration with FreeBSD ports is based on setup.py it would be so much easier to maintain it if that file was generated and uploaded. I am sure that FreeBSD is not the only OS that has this limitation, so potentially this will make porting easier for other operating systems, too.

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #896 (d676231) into master (d0c295e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #896    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           20        33    +13     
  Lines          717       864   +147     
==========================================
+ Hits           717       864   +147     
Impacted Files Coverage Δ
fastapi_users/__init__.py 100.00% <100.00%> (ø)
fastapi_users/authentication/__init__.py 100.00% <100.00%> (ø)
fastapi_users/authentication/authenticator.py 100.00% <100.00%> (ø)
fastapi_users/authentication/backend.py 100.00% <100.00%> (ø)
fastapi_users/authentication/strategy/__init__.py 100.00% <100.00%> (ø)
fastapi_users/authentication/strategy/base.py 100.00% <100.00%> (ø)
...stapi_users/authentication/strategy/db/__init__.py 100.00% <100.00%> (ø)
...astapi_users/authentication/strategy/db/adapter.py 100.00% <100.00%> (ø)
fastapi_users/authentication/strategy/db/models.py 100.00% <100.00%> (ø)
...stapi_users/authentication/strategy/db/strategy.py 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0583d7c...d676231. Read the comment docs.

@frankie567
Copy link
Member

Hi @mekanix!

Thank you for this proposal! I may not have all the ins and outs about this but, from what I understood, it sounded like setup.py was more or less deprecated. There is a long thread about this on Flit: pypa/flit#501

I wouldn't mind add this option if it's really needed on some systems, but if you could give me some insights about the status of setup.py in the Python world, it would be really helpful :)

@mekanix
Copy link
Contributor Author

mekanix commented Feb 5, 2022 via email

@frankie567
Copy link
Member

Well, I would say it doesn't harm to add this option if it helps developers out there. I was being curious about the status of setup.py as there is no clear information (at least to my knowledge) about this. (and also because I know absolutely nothing about FreeBSD 🙃)

@frankie567 frankie567 merged commit 5ed4538 into fastapi-users:master Feb 7, 2022
@frankie567
Copy link
Member

@all-contributors add @mekanix for platform

@allcontributors
Copy link
Contributor

@frankie567

I've put up a pull request to add @mekanix! 🎉

@frankie567
Copy link
Member

@mekanix Was your account compromised? 😓

@mekanix
Copy link
Contributor Author

mekanix commented Dec 1, 2022

I guess it was. I changed the password so let's see what happens now.

@mekanix mekanix deleted the feature/setup-py branch December 1, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants