Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis ci to do aarch64 builds #475

Merged
merged 2 commits into from Nov 16, 2020

Conversation

AWSjswinney
Copy link
Contributor

Build aarch64 wheels for tagged builds. Pypy is skipped on arm because
the aarch64 build of pypy is not yet available.

Additionally remove builds for Python 3.5 since its support life ended
in September 2020.

@scottbelden
Copy link
Collaborator

Thanks. I'm currently in the process of transistioning to Github Actions in a PR to add Python 3.9 and remove Python 3.5. My plan is to get that working and merged and then we'd probably want to make updates to those yml files to build the new architecture. It might be a little delayed because we use numpy for testing and they haven't built 3.9 wheels yet and so some of the tests are either taking a long time (building numpy from source) or failing (OSX requires doing some special things to properly build numpy).

@AWSjswinney
Copy link
Contributor Author

Thanks @scottbelden. I'll modify my change to do only arm64 builds with Travis and wait to rebase it once you have merged #474.

@AWSjswinney
Copy link
Contributor Author

One more question: Would you be open to migrating from Travis-CI.org to TravisCI.com? The latter supports the new, and faster, AWS Graviton 2 instances for building arm64 binaries.
See: https://blog.travis-ci.com/2020-09-11-arm-on-aws
And: https://docs.travis-ci.com/user/migrate/open-source-repository-migration

@scottbelden
Copy link
Collaborator

I don't think there would be any problem moving to travis-ci.com. Though, it's probably something that I won't do until #474 is fixed and merged.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #475 (b988547) into master (3b37d90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          25       25           
  Lines        1701     1701           
=======================================
  Hits         1673     1673           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b37d90...b988547. Read the comment docs.

@AWSjswinney
Copy link
Contributor Author

@scottbelden I rebased this PR and all the tests are passing. Let me know if you'd like me to change anything.

@scottbelden
Copy link
Collaborator

Thanks. I will try to take a look at this soon.

@scottbelden
Copy link
Collaborator

@AWSjswinney I'm assuming we should include 3.9 in the python versions, right? Or is there a reason it was left out?

Also, I think we need to add this script again as it is run when doing a tagged build to actually build the wheels: https://github.com/fastavro/fastavro/blob/f468264b0f86661f1893c8b32bc592fb44e39c75/.travis_build_wheel.sh

Build aarch64 wheels for tagged builds. Pypy is skipped on arm because
the aarch64 build of pypy is not yet available.
@AWSjswinney
Copy link
Contributor Author

I didn't leave 3.9 out on purpose. It wasn't available when I first did the work and I didn't add it back in when I rebased the other day. I added the script back in as well.

Thanks!

@scottbelden
Copy link
Collaborator

It seems like the 3.9 version is having some issues so I'm going to remove that again for the moment and try to get an initial set of wheels out. At some point I can try to add 3.9 again and see if it has better luck.

@scottbelden scottbelden merged commit 66697d2 into fastavro:master Nov 16, 2020
@AWSjswinney
Copy link
Contributor Author

Thanks for wrapping it up for me! It looks like the wheels are published and working. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants