Skip to content

Commit

Permalink
optimizations
Browse files Browse the repository at this point in the history
  • Loading branch information
dhirtzbruch committed Apr 14, 2023
1 parent 93a3a81 commit 2c2397b
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions src/WorkingDayProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ public function getWorkingDaysForPeriod(
DateTime $periodStart,
DateTime $periodEnd
): int {
$holidays = null === $this->holidayProvider
? []
: $this->indexHolidays($this->holidayProvider->getHolidaysForDateRange($periodStart, $periodEnd));
$holidays = $this->getHolidays($periodStart, $periodEnd);

// set time to 00:00:00
$startDate = DateTimeImmutable::createFromMutable($periodStart)
Expand Down Expand Up @@ -68,6 +66,19 @@ public function getWorkingDaysForPeriod(
return $numDays;
}

/**
* @param DateTime $periodStart
* @param DateTime $periodEnd
*
* @return Holiday[]
*/
private function getHolidays(DateTime $periodStart, DateTime $periodEnd): array
{
return null === $this->holidayProvider
? []
: $this->indexHolidays($this->holidayProvider->getHolidaysForDateRange($periodStart, $periodEnd));
}

/**
* Helper method to index holidays by date in format `Y-m-d`
*
Expand Down

0 comments on commit 2c2397b

Please sign in to comment.