Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-Time Substitutions can't be escaped #390

Open
fran6co opened this issue Feb 18, 2018 · 4 comments
Open

Build-Time Substitutions can't be escaped #390

fran6co opened this issue Feb 18, 2018 · 4 comments
Labels

Comments

@fran6co
Copy link
Contributor

fran6co commented Feb 18, 2018

%1, %2, %3 and %4 can't be escaped, if I want to pass %1 as part of a define Fastbuild will replace it with a path.

@ffulin
Copy link
Contributor

ffulin commented Feb 19, 2018

Sadly, you're right - there is currently no way to escape these options. The normal escape character ^ is purely a bff parse-time mechanism, so during build time, we've lost any escaping that might have been done. It should be possible to fix this, but it will need some thought to think about a clean way to do so.

@ffulin ffulin added Bug and removed Enhancement labels Feb 19, 2018
@fran6co
Copy link
Contributor Author

fran6co commented Feb 19, 2018

It could be related to => #59 Probably a fix for that one would help here too (some way to escape after the parser so you could escape spaces and %).

@ffulin
Copy link
Contributor

ffulin commented Feb 25, 2018

I think that #59 is a different issue - i.e. that's a problem with the parser not correctly handling certain cases during bff parsing, while this issue is more about escape information being persisted somehow to built time and respected at build time.

@fran6co
Copy link
Contributor Author

fran6co commented Feb 26, 2018

Adding a way to persist escape information could help to escape white spaces and fix the other issue, but yes they are different issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants