Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC include arguments can be invalid on remote workers if they are empty #523

Open
Dandielo opened this issue Jan 16, 2019 · 2 comments
Open
Labels

Comments

@Dandielo
Copy link
Contributor

Dandielo commented Jan 16, 2019

Jobs with relative include arguments passed to a remote worker are updated to absolute using the GetRemoteSourceRoot() value, this opens the possibility to end up with an include like this '-I"D:\my_workspace\" which will result in the rest of the command line to be parsed by MSVC as a single include statement.

@ffulin ffulin added the Bug label Jan 24, 2019
@ffulin
Copy link
Contributor

ffulin commented Feb 3, 2019

I'd like to ensure I we create a test to cover this case along with the fix. Could you please detail the exact string being specified for the include path on the command line (.CompilerOptions)?

@Dandielo
Copy link
Contributor Author

Dandielo commented Feb 4, 2019

This happened with an include coming from a empty string variable.

.IncludePathInVariable = ''

ObjectList( '...' )
{
.CompilerOptions + ' -I"$IncludePathInVariable$"'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants