Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable things in Medical History should look like buttons or links #192

Open
9 tasks
ericlathrop opened this issue Jul 21, 2023 · 1 comment
Open
9 tasks
Labels

Comments

@ericlathrop
Copy link
Contributor

ericlathrop commented Jul 21, 2023

Things you click on that don't look clickable:

  • The condition name, is styled like plain text, isn't an actual link, middle-click doesn't work
  • The primary date, is styled like plain text, isn't an actual link, middle-click doesn't work
  • The list of people, is styled like plain text
  • The list of medications, is styled like plain text
  • The (secondary) date, has text cursor not link cursor, missing underline, doesn't change color on hover
  • The hospital name, has text cursor, not link cursor, missing underline, doesn't change color on hover
  • The list of prodecures, is styled like plain text

Things you can't click on that look clickable:

  • "Involved in care", is blue like a link
  • "Definition", is blue like a link

Example:
image

Things that are clickable, and take you to a completely different screen, should be normal <a href="..."> links. This lets you open them in a new tab, and has way better UX (cursor changes, distinct color, hover effects, show a url on hover, accessibility).

Things that are clickable, but open popups, should either be links or buttons.

AnalogJ added a commit that referenced this issue Aug 17, 2023
@AnalogJ
Copy link
Member

AnalogJ commented Aug 17, 2023

Thanks for putting all of these UI issues together in a single list. I'm making some of these changes as part of the pagination work in the Medical History page. I'll change your list to a checklist so I can track what's been completed.

Also some of these are intended to be hidden, as they are only for debugging during development.

AnalogJ added a commit that referenced this issue Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants