Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display patient age instead of hard coded '58' Fixes #104 #138

Merged
merged 4 commits into from
May 4, 2023

Conversation

Serinus1
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

@Serinus1
Copy link
Contributor Author

@AnalogJ
Copy link
Member

AnalogJ commented Apr 27, 2023

Thanks for the PR 🥳

A large chunk of the current dashboard will actually be removed, and replaced with user configurable widgets - see #21

However that work is still in early stages, so there's no downside in making this fix for now

@AnalogJ AnalogJ changed the base branch from main to sandbox April 27, 2023 05:38
Copy link
Member

@AnalogJ AnalogJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some error handling required.

@Serinus1
Copy link
Contributor Author

Apologies. Fixed and did some testing in an updated jsfiddle. Also handles strings that look like dates.

@Serinus1 Serinus1 changed the title Display patient age instead of hard coded '58' Display patient age instead of hard coded '58' Fixes #104 Apr 27, 2023
@Serinus1 Serinus1 requested a review from AnalogJ May 3, 2023 03:50
@AnalogJ
Copy link
Member

AnalogJ commented May 4, 2023

Sorry about the delay merging this PR, I was a bit busy with the sandbox branch.

@AnalogJ AnalogJ merged commit eea7309 into fastenhealth:sandbox May 4, 2023
@AnalogJ AnalogJ mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants