Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding: resource_fhir_test.go updated: source_test.go #292

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

mohanish2504
Copy link
Contributor

@mohanish2504 mohanish2504 commented Oct 29, 2023

Added:
Added test file for resource_fhir.go.
Covers GetResourceFhir

Updated:
source_test.go wanted to make a test data entry before testing the above function.
Moved code in a function to reuse in the handler package.

update: source_test.go moved test data creating to a common logic.
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2023

CLA assistant check
All committers have signed the CLA.

@mohanish2504 mohanish2504 changed the title adding: resource_fhir_test.go adding: resource_fhir_test.go updated: source_test.go Oct 29, 2023
sepated logic to hit invalid source,resource id during test case.
@AnalogJ
Copy link
Member

AnalogJ commented Oct 30, 2023

fantastic work! Would you like me to merge this PR? or are you still using this branch to add the ListResources tests?

@mohanish2504
Copy link
Contributor Author

fantastic work! Would you like me to merge this PR? or are you still using this branch to add the ListResources tests?

I think the ListResource test might take time.
You may go ahead and merge this PR for now.
In the next PR will push Swagger docs and the ListResource test? Will that work? Should I be using any guidelines for making PRs/Branches?

@AnalogJ AnalogJ merged commit 457608f into fastenhealth:main Oct 30, 2023
3 of 5 checks passed
@AnalogJ AnalogJ mentioned this pull request Oct 30, 2023
@AnalogJ
Copy link
Member

AnalogJ commented Oct 30, 2023

In the next PR will push Swagger docs and the ListResource test? Will that work?

Sure ! Though maybe we should separate those into 2 different PRs? just so its easy to merge one if the other is still a WIP?

Should I be using any guidelines for making PRs/Branches?

just a clear branch name is good enough. ie adding-swagger-docs, listresource-handler-tests etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants