Fix Storybook #439
Merged
Fix Storybook #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 21.00% 21.00%
=======================================
Files 288 288
Lines 17285 17285
Branches 615 615
=======================================
Hits 3631 3631
Misses 13317 13317
Partials 337 337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Split tests into separate development workflow that can be included within ci file. Restrict ci to only run on pushes to main/beta branches. run dev workflow on pull requests
jean-the-coder
force-pushed
the
fix-storybook
branch
from
87e8c17
to
159743b
Compare
|
fantastic work once again. Thanks @jean-the-coder 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some compilation errors in the Storybook stories for the medical sources card component. This PR clears them up as well as updating some documentation.
Changes
serve-frontend-storybooktoserve-storybookas there isn't a backend equivalent. Can change back if you want, but I didn't think thefrontendwas needed clarification and shorter commands are easier to type.test-frontend-storybookas it was the same command asserve-storybookand doesn't actually run tests like the other test commands. This threw me for a loop as a newbie to Storybook because I was expecting the test command to exit successfully like the other test commands.build-storybookthat can be used like test commands to ensure compilation succeeds without running the server.