import https://github.com/adobe/rules_gitops/commit/0483dedecef451c68… #12
Conversation
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| body = branch | ||
| } | ||
|
|
||
| if err := gitServer.CreatePR(branch, *prInto, title, body); err != nil { | ||
| log.Fatal("unable to create PR: ", err) |
There was a problem hiding this comment.
The error handling here is quite severe. Using log.Fatal will cause the program to immediately exit, which might not be the desired behavior in all cases. If the creation of a single PR fails, it might be better to log the error and continue with the next one, rather than stopping the entire process. Consider changing this to a less severe error handling method, such as log.Error, and continue with the next iteration. This way, a single failure won't stop the entire process.
| title := *prTitle | ||
| if title == "" { | ||
| title = fmt.Sprintf("GitOps deployment %s", branch) | ||
| } | ||
|
|
||
| err := gitServer.CreatePR(branch, *prInto, *prTitle, *prBody) | ||
| if err != nil { | ||
| body := *prBody | ||
| if body == "" { | ||
| body = branch | ||
| } |
There was a problem hiding this comment.
The default values for title and body are not very descriptive. If prTitle and prBody are not provided, they are set to "GitOps deployment {branch}" and "{branch}" respectively. This might not provide enough context for someone looking at the PR. Consider providing more descriptive default values or enforcing that these values are provided by the user.
No description provided.