openal-ooc pull request #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well this, looks good, but I'm wondering why you needed to remove the types. In theory, covers from "a numeric type" should have worked as well. Especially, if state is an ALint* and AL_STOPPED is an ALint |
|
I only know that I had to change that above line from crowbarcentral-vorbis-openal to make it work with the current version of rock. Otherwise I'd get the error It's not a big thing to add the types back, but I don't see why we need them. |
|
Okay, well that was definitely a rock bug and I'd like to see it fixed, but until then I'll merge that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first fork and pull request, so I hope I did everything correctly.
Added a few more functions, by hand, from the documentation. Didn't quite know what to do with ALC and extensions, so I just left them out for now. I removed types so I don't have to type
asas much. I think this is not supposed to be that way, but I'm too afraid of opening an issue atm:If there's something (or all of it) wrong, let me know.