Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Change json-20090211_1 dependency to work on Java 9 #12

Closed
sharpTrick opened this issue Jan 12, 2018 · 5 comments
Closed

Change json-20090211_1 dependency to work on Java 9 #12

sharpTrick opened this issue Jan 12, 2018 · 5 comments

Comments

@sharpTrick
Copy link

I get this is the wrong place. But I could not find the home for geronimo bundles. Is far as I can tell is is dead.

However in my attempts to modularize my quandl library which depends on com.jimmoores:quandl-core which in turn depends on this somehow, I discovered that the automatic module naming algorithm fails to name the json-2090211_1 with a valid module name.

I have found that if the line 'Automatic-Module-Name: org.json' is added to the MANIFEST.MF in the META-INF within the json-20090211_1.jar then my library compiles.

FYI...

@cowtowncoder
Copy link
Member

Ok. So... since org.json is a dependency, and as per comment at some point this artifact has been one (of only?) variants with OSGi info, I guess it might be worth another look to see if we could do better.

Looking at this:

http://mvnrepository.com/artifact/org.json/json/20171018

I think it does have basic OSGi metadata. I could change dependency to that one (seems like a good idea in general) if that would help? This assuming it's the underscore that causes issues, and not lack 3-part "full" version number.

About the only concern here, I think (aside from OSGi metadata being broken but I assume it's not) would be change in dependencies for patch release (2.9.4).

@sharpTrick
Copy link
Author

I would wager that you are correct with the underscore hypothesis.

@cowtowncoder
Copy link
Member

Ok. So how about I'll just change the dependency in 2.9 (and master) and it should not at least hurt.

@cowtowncoder cowtowncoder changed the title java 9 module json-20090211_1 dependency Automatic-Module-Name Change json-20090211_1 dependency to work on Java 9 Jan 12, 2018
@jimmoores
Copy link

Many thanks for the fix. Any ETA on 2.9.4?

@cowtowncoder
Copy link
Member

I think the best approximation I can give is "before end of January". Hoping to clear couple of issues with jackson-databind still.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants