Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gethostbyname() with getaddrinfo() or getnameinfo() #217

Closed
jonathanspw opened this issue Aug 21, 2022 · 8 comments
Closed

Replace gethostbyname() with getaddrinfo() or getnameinfo() #217

jonathanspw opened this issue Aug 21, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@jonathanspw
Copy link
Contributor

Current state:

gethostbyname() has long been obsolete and getaddrinfo() or getnameinfo() should be used instead.

Wanted state:

Use getaddrinfo() or getnameinfo() in https://github.com/LinusDierheimer/fastfetch/blob/master/src/detection/title.c#L30

Why the change is sensible:

gethostbyname() has been obsolete for man years.

@jonathanspw jonathanspw added the enhancement New feature or request label Aug 21, 2022
@LinusDierheimer
Copy link
Collaborator

Done, thanks for pointing it out.

@LinusDierheimer
Copy link
Collaborator

LinusDierheimer commented Aug 21, 2022

Just saw that you are packaging it for fedora, thanks for that! Do you need a new point release for that?

@jonathanspw
Copy link
Contributor Author

That was quick, thank you!

I can do a patch for this for now. I'm pushing it out for Fedora Rawhide (dev branch) but I'm not pushing it to current stable releases or EPEL yet. Due to update policies we can't really push backwards-incompatible updates to normal/stable branches and since 1.6.x > 1.7.x will have such changes (the config files), I'm waiting for 1.7 to release into those branches of the OS that way hopefully updates won't get blocked by backwards-incompatible changes for a while :)

@jonathanspw
Copy link
Contributor Author

Erm,

I'm mixing up projects. I'll be pushing this to all stable versions of Fedora/EPEL that it will build on.

@LinusDierheimer
Copy link
Collaborator

I do a small release than. That way you don't need patches for this or the alma linux logo.

@jonathanspw
Copy link
Contributor Author

Works for me :)

@jonathanspw
Copy link
Contributor Author

It will be going into F35+ and EPEL8/9

@jonathanspw
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants