-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gethostbyname() with getaddrinfo() or getnameinfo() #217
Comments
Done, thanks for pointing it out. |
Just saw that you are packaging it for fedora, thanks for that! Do you need a new point release for that? |
That was quick, thank you! I can do a patch for this for now. I'm pushing it out for Fedora Rawhide (dev branch) but I'm not pushing it to current stable releases or EPEL yet. Due to update policies we can't really push backwards-incompatible updates to normal/stable branches and since 1.6.x > 1.7.x will have such changes (the config files), I'm waiting for 1.7 to release into those branches of the OS that way hopefully updates won't get blocked by backwards-incompatible changes for a while :) |
Erm, I'm mixing up projects. I'll be pushing this to all stable versions of Fedora/EPEL that it will build on. |
I do a small release than. That way you don't need patches for this or the alma linux logo. |
Works for me :) |
It will be going into F35+ and EPEL8/9 |
Current state:
gethostbyname()
has long been obsolete andgetaddrinfo()
orgetnameinfo()
should be used instead.Wanted state:
Use
getaddrinfo()
orgetnameinfo()
in https://github.com/LinusDierheimer/fastfetch/blob/master/src/detection/title.c#L30Why the change is sensible:
gethostbyname()
has been obsolete for man years.The text was updated successfully, but these errors were encountered: