Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for ddcutil 2.0.0 (1.4.1 works) #576

Closed
JamiKettunen opened this issue Oct 7, 2023 · 4 comments
Closed

Missing support for ddcutil 2.0.0 (1.4.1 works) #576

JamiKettunen opened this issue Oct 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@JamiKettunen
Copy link
Contributor

With ddcutil v2.0.0 when I run the following:

env NO_CONFIG=1 fastfetch --load-config all --show-errors --stat --multithreading false --disable-linewrap false --hide-cursor false

I only get Brightness: No result is detected. while installing ddcutil v1.4.1 makes Brightness (HPN): 89% and Brightness (VSC): 60% appear as expected.

Fwiw I was testing this on Chimera Linux with my packaging looking like chimera-linux/cports@master...JamiKettunen:cports:fastfetch

Let me know if you need any other details or if this is reproducible under another distribution with an updated ddcutil version :)

@JamiKettunen JamiKettunen added the bug Something isn't working label Oct 7, 2023
CarterLi added a commit that referenced this issue Oct 8, 2023
ddcutil 2.0 increases SONAME version to `libddcutil.so.5`. More testing needed

Ref: #576
@CarterLi
Copy link
Member

CarterLi commented Oct 8, 2023

Please make sure that ddcutil getvcp 10 works first, and try fastfetch again.

If it still doesn't work, there must be some imcompatibility between 1.4 and 2.0. The code is very simple and you may debug it. If you can't, I'll try debug it myself after Fedora upgrades ddcutil to 2.0.

@JamiKettunen
Copy link
Contributor Author

Sorry for the long delay, that seems to have done the trick. I suppose it should try both sonames since for fastfetch purposes both seem to be "compatible"? I suppose it'll crash when that's not the case but could be somehow dealt with as well if it comes up

@CarterLi
Copy link
Member

CarterLi commented Oct 9, 2023

FF_LIBRARY_LOAD will try lower versions if the specified version is not found.

@CarterLi CarterLi closed this as completed Oct 9, 2023
@Bo98
Copy link

Bo98 commented Oct 14, 2023

Looks like it broke again in e9c2a43:

  In file included from /tmp/fastfetch-20231014-20832-1ne6cfg/fastfetch-2.1.1/src/detection/brightness/brightness_linux.c:90:
  /tmp/fastfetch-20231014-20832-1ne6cfg/fastfetch-2.1.1/src/detection/brightness/brightness_linux.c: In function ‘detectWithDdcci’:
  /tmp/fastfetch-20231014-20832-1ne6cfg/fastfetch-2.1.1/src/detection/brightness/brightness_linux.c:103:48: error: ‘ddca_set_default_sleep_multiplier’ undeclared (first use in this function); did you mean ‘ddca_set_sleep_multiplier’?
    103 |     FF_LIBRARY_LOAD_SYMBOL_MESSAGE(libddcutil, ddca_set_default_sleep_multiplier)
        |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

From ddcutil release notes:

With the ability to configure libddcutil operation both by the ddcutil
configuration file and by passing an option string in the ddca_init() arguments,
several API functions are no longer needed and have been removed:

[...]

  • ddca_set_default_sleep_multiplier(), ddca_set_global_sleep_multiplier()

[...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants