Request testing of AMD card users

[yai-dev]

General description of bug:

• What happened: I had 2 gpus on my laptop: AMD integrated GPU and NVIDIA 3060 Mobile (discrete gpu), fastfetch detected AMD as dGPU but no NVIDIA 3060 Mobile
• What should happen: NVIDIA 3060 Mobile should be detected to dGPU but not AMD integrated GPU
• Fastfetch version used: fastfetch 2.10.2-debug (x86_64)
• Did it work in an older version: IDK
• Where did you get the binary: ArchLinux Offcial Repository
• Does this issue still occurs in the latest dev build?

Often helpful information:

Screenshot:

The content of the configuration file you use (if any):
There has no configuration file i used

Output of fastfetch --list-features:

threads
vulkan
wayland
xcb-randr
xcb
xrandr
x11
drm
gio
dconf
dbus
imagemagick7
chafa
zlib
xfconf
egl
glx
osmesa
opencl
libpulse
libnm
libddcutil
videodev2
Directx Headers
Proprietary GPU driver API
System yyjson

[yai-dev]

FYI: when i run fastfetch with flag --gpu-force-vulkan, outputs is correct:

[yai-dev]

I think is these codes cause wrong detection:

fastfetch/src/detection/gpu/gpu_linux.c

Line 67 in bdd2908

gpu->type = size > 1024UL * 1024 * 1024 ? FF_GPU_TYPE_DISCRETE : FF_GPU_TYPE_INTEGRATED;

[CarterLi]

I actually don't have an AMD GPU. Can you paste the result of following command here?

cat /sys/class/drm/card{0,1,2}/device/{mem_info_vram_total,mem_info_vram_used,mem_info_vis_vram_total,mem_info_vis_vram_used,mem_info_gtt_total,mem_info_gtt_used,smartshift_apu_power,smartshift_dgpu_power,smartshift_bias}

[yai-dev]

I actually don't have an AMD GPU. Can you paste the result of following command here?

cat /sys/class/drm/card{0,1,2}/device/{mem_info_vram_total,mem_info_vram_used,mem_info_vis_vram_total,mem_info_vis_vram_used,mem_info_gtt_total,mem_info_gtt_used,smartshift_apu_power,smartshift_dgpu_power,smartshift_bias}

Here is what you need:

4294967296
1009135616
4294967296
1009135616
31523540992
201281536

[CarterLi]

Seems no one can be used to identify the GPU type.

Let's disable the GPU type detection

[CarterLi]

hwmon interface seems contain interesting data. Notably

• Northbridge voltage (APUs only)
• GPU memory clock (dGPU only)

https://www.kernel.org/doc/html/v5.10/gpu/amdgpu.html#hwmon-interfaces

What do ls -l /sys/class/drm/card?/device/hwmon/hwmon?/{freq1_input, in1_input} and cat /sys/class/drm/card?/device/hwmon?/{freq1_input, in1_input} print?

[yai-dev]

hwmon interface seems contain interesting data. Notably

• Northbridge voltage (APUs only)
• GPU memory clock (dGPU only)

https://www.kernel.org/doc/html/v5.10/gpu/amdgpu.html#hwmon-interfaces

What do ls -l /sys/class/drm/card?/device/hwmon/hwmon?/{freq1_input, in1_input} and cat /sys/class/drm/card?/device/hwmon?/{freq1_input, in1_input} print?

FYI:

Output for ls -l /sys/class/drm/card0/device/hwmon/hwmon2/freq1_input

.r--r--r-- 4.1k root 29 4月  15:01 /sys/class/drm/card0/device/hwmon/hwmon2/freq1_input

Output for ls -l /sys/class/drm/card0/device/hwmon/hwmon2/in1_input

.r--r--r-- 4.1k root 29 4月  15:01 /sys/class/drm/card0/device/hwmon/hwmon2/in1_input

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/freq1_input

400000000

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/in1_input

943

It seems card1 doesn't has files or symlinks as you said but only card0 (a.k.a amdgpu)

[CarterLi]

I'm sorry. It should be cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input

And what does ls -l /sys/class/drm/card0/device/hwmon/hwmon? print?

It seems card1 doesn't has files or symlinks as you said but only card0 (a.k.a amdgpu)

It was expected. All these files are amdgpu only

[yai-dev]

I'm sorry. It should be cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input

And what does ls -l /sys/class/drm/card0/device/hwmon/hwmon? print?

It seems card1 doesn't has files or symlinks as you said but only card0 (a.k.a amdgpu)

It was expected. All these files are amdgpu only

FYI:

Output for ls -l /sys/class/drm/card0/device/hwmon/hwmon?:

lrwxrwxrwx 1 root root    0  4月29日 15:01 device -> ../../../0000:05:00.0
-r--r--r-- 1 root root 4096  4月29日 15:01 freq1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 freq1_label
-r--r--r-- 1 root root 4096  4月29日 15:01 in0_input
-r--r--r-- 1 root root 4096  4月29日 15:01 in0_label
-r--r--r-- 1 root root 4096  4月29日 15:01 in1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 in1_label
-r--r--r-- 1 root root 4096  4月29日 15:01 name
drwxr-xr-x 2 root root    0  4月29日 09:57 power
-r--r--r-- 1 root root 4096  4月29日 15:01 power1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 power1_label
lrwxrwxrwx 1 root root    0  4月29日 09:57 subsystem -> ../../../../../../class/hwmon
-r--r--r-- 1 root root 4096  4月29日 15:01 temp1_input
-r--r--r-- 1 root root 4096  4月29日 15:01 temp1_label
-rw-r--r-- 1 root root 4096  4月29日 09:57 uevent

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input:

NO SUCH FILE OR DIRECTORY

[CarterLi]

I have implemented a version. It should correctly detect the GPU type of your AMD iGPU and NV dGPU. It should also print the GPU frequency for the AMD iGPU (in your case, 0.4GHz should be printed)

https://github.com/fastfetch-cli/fastfetch/actions/runs/8878225530/artifacts/1456489814

[CarterLi]

Output for cat /sys/class/drm/card0/device/hwmon/hwmon2/freq2_input:
NO SUCH FILE OR DIRECTORY

Cool!

[yai-dev]

I have implemented a version. It should correctly detect the GPU type of your AMD iGPU and NV dGPU. It should also print the GPU frequency for the AMD iGPU (in your case, 0.4GHz should be printed)

cool, i will test it.

[CarterLi]

If you specify --gpu-driver-specific --gpu-temp, fastfetch should print more information for both iGPU and dGPU.

[yai-dev]

seems not working, emmm

[CarterLi]

https://github.com/fastfetch-cli/fastfetch/actions/runs/8878546945/artifacts/1456557467

This one please.

[yai-dev]

https://github.com/fastfetch-cli/fastfetch/actions/runs/8878546945/artifacts/1456557467

This one please.

It seems working right now, cool.

[CarterLi]

GPU temp didn't work? What does /sys/class/drm/card0/device/hwmon/hwmon?/temp1_input print?

My mistake

[yai-dev]

GPU temp didn't work? What does /sys/class/drm/card0/device/hwmon/hwmon?/temp1_input print?

My mistake

haha, dont mind, your fixing is freking fast.

[CarterLi]

This one: https://github.com/fastfetch-cli/fastfetch/actions/runs/8878762801/artifacts/1456601026

[yai-dev]

This one: https://github.com/fastfetch-cli/fastfetch/actions/runs/8878762801/artifacts/1456601026

FYI:

[CarterLi]

Does GPU temp work with --gpu-temp?

[CarterLi]

AMD driver only reports current GPU frequency, while fastfetch reports max frequency for both CPU and non-AMD GPUs. I wonder if I should remove it.

[yai-dev]

AMD driver only reports current GPU frequency, while fastfetch reports max frequency for both CPU and non-AMD GPUs. I wonder if I should remove it.

AMD driver only reports current GPU frequency, while fastfetch reports max frequency for both CPU and non-AMD GPUs. I wonder if I should remove it.

keep it if someone need it, if the freq is correct.

[yai-dev]

@CarterLi i think i need to test new gpu detection is working on Wayland, wait plz

[CarterLi]

What does /sys/class/drm/card0/device/uevent print?

[yai-dev]

@CarterLi i think i need to test new gpu detection is working on Wayland, wait plz

seems to working on Wayland.

What does /sys/class/drm/card0/device/uevent print?

[CarterLi]

What about /sys/class/drm/card0/device/revision

[yai-dev]

What about /sys/class/drm/card0/device/revision

FYI:

[yai-dev]

card1 if you needed:

[CarterLi]

I think it's enough to close this issue. Thanks for your help.