Low-risk C++11 and C++14 constexpr functions #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Let us run tests. |
|
Running tests. |
lemire
reviewed
Feb 28, 2023
| @@ -36,662 +36,663 @@ constexpr static int smallest_power_of_five = binary_format<double>::smallest_po | |||
| constexpr static int largest_power_of_five = binary_format<double>::largest_power_of_ten(); | |||
| constexpr static int number_of_entries = 2 * (largest_power_of_five - smallest_power_of_five + 1); | |||
| // Powers of five from 5^-342 all the way to 5^308 rounded toward one. | |||
| static const uint64_t power_of_five_128[number_of_entries]; | |||
There was a problem hiding this comment.
We need to make sure that the large table is included only once per project. I.e., if several compilation units include our header, we want the large table to appear only once in the final executable or library. That is why we use the strange template construction with an unused parameter.
There was a problem hiding this comment.
I am not objecting to the PR. I am just raising a flag.
|
Ok. I am satisfied that it does not obviously create bloating. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
constexprto functions where the definitions need no or just minimal change.I added the
FASTFLOAT_CONSTEXPR14to for functions that need at least C++14 to be markedconstexpr.