Adding more CXX20 testing in CI. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@leni536 Thoughts on the failing tests ? |
|
https://github.com/fastfloat/fast_float/actions/runs/4521288444/jobs/7962950990#step:3:33 Looks like gcc 9.4.0 doesn't have the three C++20 features that we are testing for, even though it allows building in C++20 mode (possibly with -std=c++2a flag in that version, CMake happily sets that). So I wouldn't enable constexpr testing in that workflow. Further errors are less relevant, but they show that several other C++20 constexpr features are missing from that compiler, like allowing uninitialized variables. |
|
@leni536 Fantastic. I had not realized at once that it was GCC 9. Fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to turn FASTFLOAT_CONSTEXPR_TESTS ON by default when C++20 is detected.