Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flate with the flate pool from fasthttp #26

Closed
mertakman opened this issue Jan 4, 2022 · 2 comments
Closed

Replace flate with the flate pool from fasthttp #26

mertakman opened this issue Jan 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@mertakman
Copy link

Fast HTTP is using well-optimized https://github.com/klauspost/compress library for compression. I think we can change it in here too, with that way we can get very nice performance and resource optimization for websocket connections with compression.
@savsgio
Copy link
Member

savsgio commented Feb 21, 2022

Hi @mertakman,

Sorry for delayed answer!

Could you make a PR please?

savsgio added a commit that referenced this issue Nov 24, 2022
@savsgio
refactor(#26): change compress/flate to github.com/klauspost/compress…
c9cb05f 
…/flate
@savsgio savsgio added the enhancement New feature or request label Nov 24, 2022
savsgio added a commit that referenced this issue Nov 24, 2022
@savsgio
fix(#26): downgrade github.com/klauspost/compress to v1.15.9
c98746c
@savsgio
Copy link
Member

savsgio commented Nov 24, 2022

Hi @mertakman,

Changed the library in v1.5.1-rc.9.

Thanks for your suggest!

@savsgio savsgio closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@savsgio @mertakman