Skip to content

Commit

Permalink
Merge pull request #88 from aichholzer/fix/update
Browse files Browse the repository at this point in the history
No version header and travis versions.
  • Loading branch information
aichholzer committed Mar 1, 2019
2 parents be36c7f + d00a650 commit 84cd946
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Expand Up @@ -2,6 +2,8 @@ language: node_js

node_js:
- "8"
- "10"
- "11"

notifications:
email:
Expand Down
4 changes: 1 addition & 3 deletions benchmark-compare.js
Expand Up @@ -58,7 +58,7 @@ if (!choices.length) {
let data = readFileSync(`${resultsPath}/${result}.json`)
data = JSON.parse(data.toString())
const beBold = result === 'fastify'
const { version = 'N/A', hasRouter = false } = info(result) || {}
const { hasRouter = false } = info(result) || {}
table.push([
bold(beBold, chalk.blue(result)),
bold(beBold, hasRouter ? '✓' : '✗'),
Expand Down Expand Up @@ -87,7 +87,6 @@ if (!choices.length) {
const table = new Table({
head: [
'',
'Version',
'Router',
`Requests/s\n(% of ${base.name})`,
`Latency\n(% of ${base.name})`,
Expand All @@ -101,7 +100,6 @@ if (!choices.length) {

table.push([
bold(beBold, chalk.blue(result.server)),
bold(beBold, version),
bold(beBold, hasRouter ? '✓' : '✗'),
bold(beBold, `${result.requests.mean}\n(${getPct(base.request, result.requests.mean)})`),
bold(beBold, `${result.latency.mean}\n(${getPct(base.latency, result.latency.mean)})`),
Expand Down

0 comments on commit 84cd946

Please sign in to comment.