Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ESM #220

Closed
2 tasks done
RafaelGSS opened this issue Dec 26, 2021 · 4 comments
Closed
2 tasks done

Add support to ESM #220

RafaelGSS opened this issue Dec 26, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@RafaelGSS
Copy link
Member

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

Frequently modules are dropping support to CommonJS and in order to keep it up to date, we should support the ESM as soon as possible

Motivation

#216

Example

No response

@RafaelGSS RafaelGSS added the good first issue Good for newcomers label Dec 26, 2021
@jsumners
Copy link
Member

I rather just remove the offending modules.

@ikmrgrv
Copy link

ikmrgrv commented Apr 12, 2022

I rather just remove the offending modules.

What's wrong with keeping things up-to-date and dropping legacy supports ??
Just curious to know what's the pain point in adding support to ESM. If possible, what could be the strategy and how can I help to bring this upgrade ??

@jsumners
Copy link
Member

  1. CJS isn't "legacy"
  2. ESM does not work the same way
  3. ESM is not instrumentable

@Turbine1991
Copy link

There are limitations in interoperability, while ESM can import CJS, CJS cannot require ESM, because it would break the synchronous constraint.

If this is still true, one may want to reconsider. Currently Fastify works just fine in my ESM project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants