Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump chalk from 4.1.2 to 5.0.0" #228

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Feb 2, 2022

CI is failing due this merge.

Reverts #221

@RafaelGSS
Copy link
Member

Yeah, actually, I have opened #220 because of that. So, you can either:

  • disable dependabot major updates for those modules
  • support esm

@Eomm
Copy link
Member Author

Eomm commented Feb 2, 2022

I would go for the first option.

I get a notification for major update in every case

@RafaelGSS
Copy link
Member

Could you add it to this PR then? Otherwise, this PR likely will be suppressed by the next dependabot iteration

@Eomm
Copy link
Member Author

Eomm commented Feb 2, 2022

Sorry, I mean that dependabot will open the PR but automerge will not merge it.

So we have the notification, without issue.

I have added the target argument for this purpose

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS RafaelGSS merged commit 9f0733c into master Feb 2, 2022
@Eomm Eomm deleted the revert-221-dependabot/npm_and_yarn/chalk-5.0.0 branch February 20, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants