Choices. Compare. Version. #55
Conversation
aichholzer
commented
May 18, 2018
aichholzer
commented
- Removed choice duplication.
- Compare all results as a table.
- Compare only based on available results.
- Version bump.
- Updated readme.
…d on available results. Version bump. Updated readme.
|
Nice work! Would you mind updating the table and the files so that it can print something that can copy-pasted in https://github.com/fastify/fastify#benchmarks? |
|
@mcollina -Will do, no worries. I have a PR already lined up for fastify with a new table and updated benchmarks section. Whichever works for you, if you prefer to do it yourself. |
aichholzer
force-pushed
the
master
branch
3 times, most recently
from
1544bc4
to
084d779
Compare
…dme benchmarks. Updated modules.
README.md
Outdated
| take-five | ✓ | 28305.6 | 3.14 | 9.55 | ||
| total.js | ✓ | 27176 | 3.59 | 7.75 | ||
| trek-engine | ✗ | 32137.6 | 3.03 | 4.59 | ||
| trek-engine-router | ✓ | 33908.81 | 2.87 | 4.88 |
There was a problem hiding this comment.
Can you rerun this on Node 8? We target latest LTS, and Node 10 has currently serious bugs that prevents it to be a solid production runtime :/.
README.md
Outdated
|
|
||
| [](https://asciinema.org/a/SA9z6g2HjOr0n80KwEvUaWoSS) | ||
| | Router | Requests/s | Latency | Throughput/Mb | ||
| ------------------------ | :------: | ---------: | ------: | ------------: |
There was a problem hiding this comment.
Can you add a 'version' column? It's very important.
|
@mcollina -Done. I did some additional refactoring to allow version and router availability to be read automatically from the |
There was a problem hiding this comment.
LGTM
Would you like to help maintaining this @aichholzer? We would love to have you on the team!
|
Glad to hear @mcollina and yes, happy to maintain this. |
