'node_modules/@fastify/busboy/lib/utils.js': TypeError: Value is not an object: undefined

[Tom3652]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

See in firebase-admin SDK (messaging)

Plugin version

See in firebase-admin SDK (messaging)

Node.js version

MongoDB Atlas Trigger : JS SDK Version: 3.18.0

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

No idea sorry

Description

I don't know NodeJS at all sorry, but i am using the firebase_admin package that is actually using your package as a dependency.

I have no clue about it but since they don't answer to my issue there.
I am making an issue here so perhaps you could tell me what is happening :

'http' module: FunctionError: failed to execute source for 'node_modules/@fastify/busboy/lib/main.js': FunctionError: failed to execute source for 'node_modules/@fastify/busboy/deps/dicer/lib/Dicer.js': FunctionError: failed to execute source for 'node_modules/@fastify/busboy/deps/dicer/lib/HeaderParser.js': FunctionError: failed to execute source for 'node_modules/@fastify/busboy/lib/utils.js': TypeError: Value is not an object: undefined
	at node_modules/@fastify/busboy/lib/utils.js:23:27(322)

	at require (native)
	at node_modules/@fastify/busboy/deps/dicer/lib/HeaderParser.js:15:24(29)

	at require (native)
	at node_modules/@fastify/busboy/deps/dicer/lib/Dicer.js:19:28(39)

	at require (native)
	at node_modules/@fastify/busboy/lib/main.js:28:21(44)

I must specify that this error is not impacting my service, but i am having multiple errors in my Atlas trigger because of this.

Steps to Reproduce

You will find all the detail in the mentioned issue.

Expected Behavior

This error could be more explicit (with the wrong value logged for example).

I would especially really appreciate you tell me what can be wrong here or answer directly in the Firebase repo with what's wrong in their code please.

[kibertoad]

I'll take a look, thanks!

[Eomm]

Not sure if it is related, but when I see dicer, I recall it:
https://security.snyk.io/package/npm/dicer

[kibertoad]

@Eomm It used to be the case, but @Uzlopak fixed security vulnerabilities in our fork.

[lahirumaramba]

@kibertoad IIUC it looks like HeaderParser uses getLimit() from libs/utils... do you think we can movegetLimit out of utils or move to Dicer? Happy to submit a PR if this makes sense to you. Thanks!

busboy/lib/utils.js

Line 177 in 05c990c

function getLimit (limits, name, defaultLimit) {

[Tom3652]

Hello guys,
I am sorry to ask but is that meaning the issue is solved ? I can check it ?
Thanks for your work

[Uzlopak]

Yes, we released 1.2.0 today. Please Check