Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mention of @fastify/autoload in Readme #46

Merged
merged 1 commit into from
Mar 15, 2023
Merged

chore: add mention of @fastify/autoload in Readme #46

merged 1 commit into from
Mar 15, 2023

Conversation

ekynoxe
Copy link
Contributor

@ekynoxe ekynoxe commented Mar 15, 2023

Fix for fastify/help#760

The discussion stemmed from an SO answer which was erroneous, suggesting @fastify/autoload maxDepth's defaults to 2 when it does not.
The conversation hinted at create-fastify not having sufficient information that it is using autoload with default options, which this PR resolves.

Checklist

@simoneb
Copy link

simoneb commented Mar 15, 2023

What's the url of the wrong SO question?

@ekynoxe
Copy link
Contributor Author

ekynoxe commented Mar 15, 2023

@simoneb I have just updated the description

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b82c5e6 into fastify:master Mar 15, 2023
@ekynoxe ekynoxe deleted the chore/update-readme branch March 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants