-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(index): support json schema format keyword again #52
Conversation
Pull Request Test Coverage Report for Build 701946363
💛 - Coveralls |
Pull Request Test Coverage Report for Build 701282640
💛 - Coveralls |
Instead of adding the support one by one. I suggest to allow user pass a custom |
Can you add a note on the README about this? I would also ask if it would make sense to bump the Ajv dep to 8.0.0 and use ajv-formats@2.0.1. |
Best to close this PR and wait for #49 then? |
I just landed that |
Great! 👍 Rebased and updated to 2.0.1 |
what about this @Fdawgs ? |
Sounds like a separate piece of work from this fix, is it not @climba03003? |
@Fdawgs I think it is like another solution to the issue. It pass the responsibility to the user (we only provide minimal validation, they can expend it on their needs) and increase the flexibility of validation. |
I agree with @climba03003 |
@climba03003 @mcollina FYI got it on my todo list to come back and refactor the plugin to support this (unless someone beats me to it), so not forgotten! |
no worries |
closes #48
AJV v6 supported the JSON Schema format keyword however, with v7, this functionality has been moved to a separate module.
This PR simply adds that module.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct