improve benchmark workflow #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
requested review from
Fdawgs,
RafaelGSS and
ivan-tymoshenko
and removed request for
Fdawgs,
RafaelGSS and
ivan-tymoshenko
|
To see the output, see |
Fdawgs
reviewed
Jul 28, 2023
| @@ -31,7 +22,7 @@ jobs: | |||
|
|
|||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: ${{ matrix.node-version }} | |||
| node-version: 18 | |||
There was a problem hiding this comment.
Set this to lts/* so we don't have to keep bumping it?
There was a problem hiding this comment.
I will anyway open an issue regarding general benchmark wf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesnt make sense to make a benchmark accross libs. What we need is the benchmark between branches.
This changes the benchmark to benchmark between two branches when adding the benchmark label.
Also reducing the maxSample to 100, as doing 500 samples takes a million years and is not more reliable.
Checklist
npm run testandnpm run benchmarkand the Code of conduct