perf: avoid domainToAscii on pure lowercase ascii cases

[Uzlopak]

before:

fast-uri: parse domain x 691,379 ops/sec ±0.47% (94 runs sampled)
urijs: parse domain x 316,209 ops/sec ±0.41% (95 runs sampled)
WHATWG URL: parse domain x 2,326,414 ops/sec ±0.33% (90 runs sampled)
fast-uri: parse IPv4 x 1,658,275 ops/sec ±0.25% (96 runs sampled)
urijs: parse IPv4 x 277,154 ops/sec ±0.95% (93 runs sampled)
fast-uri: parse IPv6 x 707,699 ops/sec ±0.29% (95 runs sampled)
urijs: parse IPv6 x 210,365 ops/sec ±1.34% (91 runs sampled)
fast-uri: parse URN x 1,682,084 ops/sec ±0.25% (96 runs sampled)
urijs: parse URN x 813,089 ops/sec ±0.24% (94 runs sampled)
WHATWG URL: parse URN x 3,321,670 ops/sec ±0.30% (91 runs sampled)
fast-uri: parse URN uuid x 1,175,383 ops/sec ±0.26% (94 runs sampled)
urijs: parse URN uuid x 604,137 ops/sec ±0.24% (92 runs sampled)
fast-uri: serialize uri x 945,225 ops/sec ±0.80% (95 runs sampled)
urijs: serialize uri x 284,622 ops/sec ±0.30% (92 runs sampled)
fast-uri: serialize IPv6 x 337,427 ops/sec ±0.66% (94 runs sampled)
urijs: serialize IPv6 x 183,875 ops/sec ±0.61% (96 runs sampled)
fast-uri: serialize ws x 902,500 ops/sec ±0.23% (96 runs sampled)
urijs: serialize ws x 253,735 ops/sec ±0.21% (94 runs sampled)
fast-uri: resolve x 249,328 ops/sec ±0.66% (95 runs sampled)
urijs: resolve x 164,304 ops/sec ±0.20% (97 runs sampled)

after:

fast-uri: parse domain x 1,180,480 ops/sec ±0.34% (90 runs sampled)
urijs: parse domain x 322,980 ops/sec ±0.17% (97 runs sampled)
WHATWG URL: parse domain x 2,340,656 ops/sec ±0.34% (94 runs sampled)
fast-uri: parse IPv4 x 1,594,761 ops/sec ±0.67% (93 runs sampled)
urijs: parse IPv4 x 273,783 ops/sec ±0.96% (95 runs sampled)
fast-uri: parse IPv6 x 691,538 ops/sec ±0.25% (88 runs sampled)
urijs: parse IPv6 x 214,914 ops/sec ±1.48% (93 runs sampled)
fast-uri: parse URN x 1,815,279 ops/sec ±0.25% (96 runs sampled)
urijs: parse URN x 863,531 ops/sec ±0.20% (95 runs sampled)
WHATWG URL: parse URN x 3,293,837 ops/sec ±0.30% (93 runs sampled)
fast-uri: parse URN uuid x 1,216,795 ops/sec ±0.21% (95 runs sampled)
urijs: parse URN uuid x 628,702 ops/sec ±0.18% (95 runs sampled)
fast-uri: serialize uri x 952,087 ops/sec ±0.61% (94 runs sampled)
urijs: serialize uri x 283,889 ops/sec ±0.35% (94 runs sampled)
fast-uri: serialize IPv6 x 338,960 ops/sec ±0.80% (96 runs sampled)
urijs: serialize IPv6 x 180,274 ops/sec ±0.58% (96 runs sampled)
fast-uri: serialize ws x 938,850 ops/sec ±0.29% (94 runs sampled)
urijs: serialize ws x 255,779 ops/sec ±0.21% (96 runs sampled)
fast-uri: resolve x 241,644 ops/sec ±1.24% (93 runs sampled)
urijs: resolve x 159,649 ops/sec ±1.25% (89 runs sampled)

Only thing i want to note:
nodes own: URL.domainToAscii('1') returns '0.0.0.1', the same for URL.domainToAscii('11') returns '0.0.0.11',
So basically transforms the decimal notation to the dot notation. Is this neglectable?

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[zekth]

Are we testing this branch in the tests? I'm not sure 🤔

[mcollina]

lgtm

[zekth]

nodes own: URL.domainToAscii('1') returns '0.0.0.1', the same for URL.domainToAscii('11') returns '0.0.0.11',
So basically transforms the decimal notation to the dot notation. Is this neglectable?

I'd say yes.

Can regex be replaced by just a cursor on the string? We tried to remove the maximum of regex from the original codebase

[Uzlopak]

Can regex be replaced by just a cursor on the string? We tried to remove the maximum of regex from the original codebase

I have no clue what you mean with "just a cursor on the string".

Do you want to iterate over the string?

[zekth]

Yes, sometimes it's faster. Really depends on the case.

[Uzlopak]

Something like

const hexLookUp = Array.from({ length: 256 }, (v, k) => /[^!"$&'()*+,.;=_`a-z{}~-]/.test(String.fromCharCode(k)))

function nonSimpleDomain (value) {
  let code = 0
  for (var i = 0, len = value.length; i < len; ++i) {
    code = value.charCodeAt(i)
    if (code > 255 || hexLookUp[code]) {
      return true
    }
  }
  return false
}

[zekth]

Yup!

[Uzlopak]

@zekth
PTAL

[mcollina]

lgtm

[zekth]

LGTM

(sorry for the late review)

[Uzlopak]

@zekth if Numbers are neglectable, we could add numbers to the lookup

[zekth]

we might also add capital letters A-Z don't you think?

[Uzlopak]

Let me investigate