Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(index): convert unused capture groups to non-capture groups #74

Merged
merged 4 commits into from
Oct 23, 2023
Merged

perf(index): convert unused capture groups to non-capture groups #74

merged 4 commits into from
Oct 23, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 21, 2023

See fastify/fastify-autoload#330

Checklist

@Fdawgs Fdawgs requested a review from Uzlopak October 22, 2023 06:48
@zekth
Copy link
Member

zekth commented Oct 22, 2023

@Uzlopak coud you take a look?

mcollina
mcollina approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs merged commit 22715af into main Oct 23, 2023
25 checks passed
@Fdawgs Fdawgs deleted the perf/lib branch October 23, 2023 07:13
@Eomm Eomm mentioned this pull request Nov 17, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fdawgs @zekth @mcollina