Prepare fastify-accepts-serializer master for v2

[cemremengu]

This is for preparing master branch for v2.

I think there is still work to be done such as:

• Removing boom
• Using only tap for testing

but I it's better to include those in the real next branch I think once we merge this 😄

[coveralls]

Coverage decreased (-3.9%) to 93.671% when pulling 3152cba on next into f802dda on master.

[cemremengu]

Not sure why coveralls decreases 50% 😄

[mcollina]

LGTM

[cemremengu]

There might be a problem with tests here. I think they are not running properly.

[mcollina]

cc @allevo?

[cemremengu]

I think I found it, trying to fix. In plugin definition it begins with

fastify.register(require('fastify-accepts'), err => {

Looks like register doesnt have a callback any more?

reply.store.config.serializer also doesnt seem to exist anymore. Converting to reply.serializer

[mcollina]

+1

[cemremengu]

What is the current equivalent this?

const config = {
  serializer: {
    serializers: [
      {
        regex: /^application\/yaml$/,
        serializer: body => 'my-custom-string'
      },
      {
        regex: /^application\/x-msgpack$/,
        serializer: body => 'my-custom-string-msgpack'
      }
    ]
  }
}

fastify.get('/request', { config }, function (req, reply) {
  reply.send({pippo: 'pluto'})
})

Currently only at the route level I guess like:

  fastify.get('/request2', function (req, reply) {
    reply
    .header('Content-Type', 'application/x-msgpack')
    .serializer(_ => 'my-custom-string-msgpack')
    .send({ pippo: 'pluto' })
  })

[cemremengu]

I seem to have fixed tests but they fail. There are 3 groups of tests and each pass on their own but not together. Couldn't figure out why they are interfering with each other 🤔

[allevo]

This work correctly?

[cemremengu]

Strangely yes. You can take this one over if you want.

[cemremengu]

Ok not strangely actually since this is still against fastify 1.x. This work is just for getting everything up to date and marking the transition.

nevermind this 😄

[allevo]

this is needed by CI

[cemremengu]

It can work without that actually. tap can automatically forward to coveralls.

https://github.com/cemremengu/fastify-oracle/blob/master/package.json#L6

Let me see if that works

[allevo]

I 've added "COVERALLS_REPO_TOKEN" env var during the build. So the coverage will be sent automatically to coveralls (I hope)

[allevo]

LGTM

Thanks a lot!!

[cemremengu]

@allevo no problem it was a good challenge and practice, thanks for bearing with me! 😄

[mcollina]

LGTM