Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preparation for fastify@5 #165

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: preparation for fastify@5 #165

merged 1 commit into from
Mar 20, 2024

Conversation

bilalshareef
Copy link
Contributor

Ref: fastify/fastify#5116

Checklist

@bilalshareef
Copy link
Contributor Author

Please create a next branch for this pull request.
@simoneb

@simoneb
Copy link

simoneb commented Mar 19, 2024

done

simoneb
simoneb approved these changes Mar 19, 2024
View reviewed changes
Copy link

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilalshareef bilalshareef changed the base branch from master to next March 19, 2024 12:47
@nrayburn-tech
Copy link

I think this should be updated as well.

fastify-accepts/index.js

Line 58 in aa42208

fastify: '4.x',

fastify/any-schema-you-like#56 (comment)

@bilalshareef
Copy link
Contributor Author

I think this should be updated as well.

fastify-accepts/index.js

Line 58 in aa42208

fastify: '4.x',

fastify/any-schema-you-like#56 (comment)

@nrayburn-tech, Updating the version here leads to FST_ERR_PLUGIN_VERSION_MISMATCH error. So this change can be made only after Fastify v5 is released and available.

@gurgunday gurgunday merged commit 8b0c105 into fastify:next Mar 20, 2024
14 checks passed
@synapse synapse mentioned this pull request Mar 22, 2024
Open
jsumners pushed a commit that referenced this pull request Jun 28, 2024
@bilalshareef @jsumners
Update for v5 (#165)
7b9e6cf
jsumners added a commit that referenced this pull request Jun 29, 2024
@jsumners @bilalshareef
Merge next into master (#167)
aed64b0 
* Update for v5 (#165)

* Update for v5 (#165)

* update deps

---------

Co-authored-by: Mohammed Bilal Shareef <bilalshareef.h@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v5 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bilalshareef @simoneb @nrayburn-tech @gurgunday