feat: Introducing the default relation plugin option #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
mcollina
requested changes
Sep 13, 2022
test/auth.test.js
Outdated
Comment on lines
46
to
47
| app.register(fastifyAuth, { defaultRelation: 'or' }) | ||
| .after(() => { |
There was a problem hiding this comment.
I didn't get it, could you elaborate more?
There was a problem hiding this comment.
Sorry: instead of after, use await.
There was a problem hiding this comment.
done, committed the changes
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Eomm
reviewed
Sep 15, 2022
Signed-off-by: iifawzi <iifawzie@gmail.com>
Eomm
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iifawzi iifawzie@gmail.com
Hi, this PR is adding the
defaultRelationoption that can be used as a plugin option to eliminate the need of specifying the relation in each routeresolving: #170
Checklist
npm run testandnpm run benchmarkand the Code of conduct