Tests are failing on windows

[cemremengu]

Most tests are failing for me due to comparison errors like

test/generate.js .................................... 47/67
  finish succesfully if package.json is there - npm
  not ok \app.js matching
    +++ found
    --- wanted



                      require('fastify-autoload')

                 ts = function (fastify, opts, next) {
                                 code!

                             llowing lines

                     all plugins defined in plugins
              e should be support plugins that are reused


                         _dirname, 'plugins'),
                              n({}, opts)


                   s all plugins defined in services
                           s in one of these

                        __dirname, 'services'),
                              n({}, opts)


                             ext when done


    +'use strict'
    +
    +const path = require('path')
    +const AutoLoad = require('fastify-autoload')
    +
    +module.exports = function (fastify, opts, next) {
    +  // Place here your custom code!
    +
    +  // Do not touch the following lines
    +
    +  // This loads all plugins defined in plugins
    +  // those should be support plugins that are reused
    +  // through your application
    +  fastify.register(AutoLoad, {
    +    dir: path.join(__dirname, 'plugins'),
    +    options: Object.assign({}, opts)
    +  })
    +
    +  // This loads all plugins defined in services
    +  // define your routes in one of these
    +  fastify.register(AutoLoad, {
    +    dir: path.join(__dirname, 'services'),
    +    options: Object.assign({}, opts)
    +  })
    +
    +  // Make sure to call next when done
    +  next()
    +}

The expected stuff is coming out garbled. I am suspecting \r\n situation but I couldn't figure out the reason so shamelessly posting here. 😄

Any ideas?

[mcollina]

We’ll just have to fix things, and maybe add Windows testing as well so we do not regress. Il giorno ven 12 ott 2018 alle 12:46 Cemre Mengu <notifications@github.com> ha scritto:

…

Most tests are failing for me due to comparison errors like test/generate.js .................................... 47/67 finish succesfully if package.json is there - npm not ok \app.js matching +++ found --- wanted require('fastify-autoload') ts = function (fastify, opts, next) { code! llowing lines all plugins defined in plugins e should be support plugins that are reused _dirname, 'plugins'), n({}, opts) s all plugins defined in services s in one of these __dirname, 'services'), n({}, opts) ext when done +'use strict' + +const path = require('path') +const AutoLoad = require('fastify-autoload') + +module.exports = function (fastify, opts, next) { + // Place here your custom code! + + // Do not touch the following lines + + // This loads all plugins defined in plugins + // those should be support plugins that are reused + // through your application + fastify.register(AutoLoad, { + dir: path.join(__dirname, 'plugins'), + options: Object.assign({}, opts) + }) + + // This loads all plugins defined in services + // define your routes in one of these + fastify.register(AutoLoad, { + dir: path.join(__dirname, 'services'), + options: Object.assign({}, opts) + }) + + // Make sure to call next when done + next() +} I am suspecting \r\n situation but I couldn't figure out the reason so shamelessly posting here. 😄 Any ideas? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#112>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADL44OreYkqP5KTqD1BKZ45XZVqnFbkks5ukPGDgaJpZM4XaFhB> .

[cemremengu]

Maybe enable appveyor on all repos? Would that help?

[mcollina]

I think we should try Travis Windows support here: https://blog.travis-ci.com/2018-10-11-windows-early-release. WDYT?

[cemremengu]

Agreed, looks good!