Add -watch option to dev task #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wouldn't it makes sense to add the `-watch` option to the dev task?
Eomm
approved these changes
Jan 10, 2020
Eomm
requested changes
Jan 10, 2020
There was a problem hiding this comment.
Ci is failing due this change
https://travis-ci.org/fastify/fastify-cli/jobs/634795649?utm_medium=notification&utm_source=github_status
Would you mind to fix it? 😁
The pull request fastify#215 breaks the tests, because the test dev task command is no longer equal with the dev task which is defined in `package.json`. See also: https://travis-ci.org/fastify/fastify-cli/jobs/634795649?utm_medium=notification&utm_source=github_status
What a great first pull request of mine ;-) |
Eomm
approved these changes
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wouldn't it makes sense to add the
-watchoption to the dev task?