Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance generated VS Code configuration #485

Merged
merged 3 commits into from May 17, 2022

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented May 15, 2022

Enhanced the generated VS Code configuration for a cleaner experience. Also simplified the dev command for the TypeScript template and removed nodemon. (P.S. Do we need ts-node?)

There is also the node-terminal launch configuration type for launch.json, but I'm not sure what is the difference in it in contrast to node. pwa-node is just a leftover from the debugger rewrite from a while back, and node is now the same thing.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, code looks good!

@fastify/typescript could you take a look?

@fox1t
Copy link
Member

fox1t commented May 16, 2022

@segevfiner, as far as I remember, ts-node is needed by tap. I have one more question: what do you think of using https://tsup.egoist.sh for the dev ts compilation? It is a way faster and better dev experience. You can check an example here: https://github.com/fox1t/typescript-microservice-starter

tsc is still used for type-checking. Let me know what you think.

@segevfiner
Copy link
Contributor Author

Heard of it, but haven't tried it. There are many ways of transpiling TS, so it can get quite opinionated. So what option we use by default should be carefully evaluated, and we might want multiple options.

@fox1t
Copy link
Member

fox1t commented May 16, 2022

@segevfiner, I agree 100% with you. We can go with tsc knowing it is slow and generally is not used in the wild, and we might open a new PR in the future to let the user pick the compiler.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 330c7c6 into fastify:master May 17, 2022
@segevfiner segevfiner mentioned this pull request May 19, 2022
2 tasks
@segevfiner segevfiner deleted the enhanced-vscode-config branch May 19, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants