Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of build in helper #651

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix return type of build in helper #651

merged 1 commit into from
Feb 8, 2024

Conversation

BryanAbate
Copy link
Contributor

@BryanAbate BryanAbate commented Aug 9, 2023 •
edited

The call to typeof was missing so build type was incorrect and returned any.

Checklist

mcollina
mcollina approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jordanebelanger
Copy link

Just ran into this issue, wondering if this could be merged 🙏

@mcollina mcollina merged commit 8915111 into fastify:master Feb 8, 2024
15 checks passed
@mcollina
Copy link
Member

mcollina commented Feb 8, 2024

I 100% forgot

@wa-Nadoo wa-Nadoo mentioned this pull request Feb 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BryanAbate @jordanebelanger @mcollina