fix: make-promises-safe is no longer required #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make-promises-safe is not required in Node.js 15+. I presumed this would be non-breaking for fastify-cli because the test matrix is only 18, 20 & 21. I left in the tests that were added when make-promises-safe was added, and they continue to pass locally on Node.js 20 & 21. I have an issue with the tests in master hanging in Node 18, so couldn't confirm that certainly but there weren't any failures before the hang.
Checklist
npm run test
and the Code of conduct