New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: achieve 100% code coverage #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pression' header
… true and `encoding` is undefined
…s true on `x-no-compression` header
…ixed in fastify upstream
mcollina
reviewed
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work!
darkgl0w
changed the title
test: improve coverage (WIP)
test: achieve 100% code coverage
Nov 24, 2021
The PR is ready for reviews. |
Thanks, this is amazing! |
mcollina
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
adm-zip
as a new dev-dep in order to test a specific use caseonSend
hook triggers as it was fixed infastify
upstream (possible regressions are monitored by a test case)This PR needs a little bit of work to be completed but early reviews are welcome ^^EDIT: it is now ready to be reviewed
Note : Tests and files should be reorganized and structured but I will do this in a new PR (reviewing will be a pain otherwise).
To be done :
xxx.test.js
convention)async
/await
syntax test pathmain branch :
after :
Checklist
npm run test
and the Code of conduct