Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export integrated cookie functionality #263

Merged
merged 5 commits into from Nov 25, 2023
Merged

export integrated cookie functionality #263

merged 5 commits into from Nov 25, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 14, 2023

This way we can use it in fastify/secure-session and co instead of the cookie package.

Checklist

gurgunday
gurgunday approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

mcollina
mcollina requested changes Nov 15, 2023
View reviewed changes
cookie.js Show resolved Hide resolved
mcollina
mcollina requested changes Nov 15, 2023
View reviewed changes
plugin.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 15, 2023

@mcollina PTAL

@mcollina
Copy link
Member

Plase require the entrypoint file in

fastify-cookie/test/cookie-module.test.js

Line 6 in efea671

const cookie = require('../cookie')
.

jsumners
jsumners reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the other module is going to use @fastify/cookie to manage cookies, why do we need to export the underlying tooling?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 20, 2023

@mcollina
PTAL

mcollina
mcollina requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document it in the README?

Fdawgs
Fdawgs reviewed Nov 25, 2023
View reviewed changes
README.md Outdated
@@ -11,6 +11,8 @@ This plugin's cookie parsing works via Fastify's `onRequest` hook. Therefore,
you should register it prior to any other `onRequest` hooks that will depend
upon this plugin's actions.

It is also possible to import the low-level cookie parsing and serialization functions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link here to the header section regarding the import?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 25, 2023

@mcollina PTAL

@gurgunday
Thank you for your work.

mcollina
mcollina approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0c7351c into master Nov 25, 2023
21 checks passed
@gurgunday gurgunday deleted the export-integrated-cookie branch November 25, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

@gurgunday gurgunday gurgunday approved these changes

@climba03003 climba03003 Awaiting requested review from climba03003

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Uzlopak @mcollina @jsumners @Fdawgs @gurgunday