Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the healthcheck optional #26

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Make the healthcheck optional #26

merged 4 commits into from
Nov 15, 2019

Conversation

delvedor
Copy link
Member

By default, fastify-elasticsearch will try to ping the cluster as soon as you start Fastify, but in some cases, pinging may not be supported due to the user permissions.
This pr adds a new option to disable that initial ping.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit ea4382b into master Nov 15, 2019
@delvedor delvedor deleted the optional-ping branch November 15, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants