feat: preparation for fastify@5 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
reviewed
Mar 14, 2024
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com>
gurgunday
approved these changes
Mar 17, 2024
|
Is this good to merge? |
We need some clarification on the next step in |
|
I see you merged though |
|
I double checked others repository and how it's done. So, I merged it. |
|
Roger, makes sense |
jsumners
pushed a commit
that referenced
this pull request
Jul 17, 2024
* update for v5 * Update .github/workflows/ci.yml Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> * reverted Tap back to v16 * upgraded tap to 18 --------- Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
jsumners
added a commit
that referenced
this pull request
Jul 22, 2024
* feat: preparation for fastify@5 (#127) * update for v5 * Update .github/workflows/ci.yml Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> * reverted Tap back to v16 * upgraded tap to 18 --------- Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> * feat: preparation for fastify@5 (#127) * update for v5 * Update .github/workflows/ci.yml Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> * reverted Tap back to v16 * upgraded tap to 18 --------- Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> * update fastify deps * update fastify deps * update fastify deps --------- Signed-off-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fastify/fastify#5116
Checklist
npm run testandnpm run benchmarkand the Code of conduct