Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crossdomain and feature policy #30

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Add crossdomain and feature policy #30

merged 2 commits into from
Nov 12, 2018

Conversation

AndersCan
Copy link
Contributor

mcollina
mcollina approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 22eef52 into fastify:master Nov 12, 2018
@AndersCan
Copy link
Contributor Author

Sorry @mcollina, but I noticed today when doing the types that crossdomain is named permittedCrossDomainPolicies in helmet.js.

I've fixed this in my new branch. Will make the PR asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersCan @mcollina