Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable license checking #77

Merged
merged 4 commits into from Aug 4, 2022
Merged

ci: enable license checking #77

merged 4 commits into from Aug 4, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 2, 2022

See fastify/workflows#49

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

Package "@assemblyscript/loader@0.10.1" is licensed under "Apache-2.0" which is not permitted by the --onlyAllow flag. Exiting.

fastify/workflows#50

@Fdawgs
Copy link
Member Author

Fdawgs commented Aug 2, 2022

@Uzlopak, GitHub Actions seem a bit sluggish today and there's been a few just timing out, not too sure if there's an issue with them. Will try rerunning these tomorrow.

@Eomm
Copy link
Member

Eomm commented Aug 2, 2022

New error

Package "hdr-histogram-js@2.0.3" is licensed under "BSD*" which is not permitted by the --onlyAllow flag. Exiting.

@Fdawgs
Copy link
Member Author

Fdawgs commented Aug 2, 2022

New error


Package "hdr-histogram-js@2.0.3" is licensed under "BSD*" which is not permitted by the --onlyAllow flag. Exiting.

Will review tomorrow, and most likely raise an issue in their repo to fix their license identifier

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2022

Hi @Fdawgs

created a PR for them ;)

HdrHistogram/HdrHistogramJS#46

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 3, 2022

@Fdawgs

We could add BSD* as additional license and make it merge ready.

@Fdawgs
Copy link
Member Author

Fdawgs commented Aug 4, 2022

@Fdawgs

We could add BSD* as additional license and make it merge ready.

Sure, will update and merge, and keep an eye on HdrHistogram/HdrHistogramJS#46

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 88a8d7e into main Aug 4, 2022
@Uzlopak Uzlopak deleted the Fdawgs-patch-1 branch August 4, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants