Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ECDSA key pair generation and related documentation #191

Merged
merged 2 commits into from Nov 22, 2021
Merged

fix: ECDSA key pair generation and related documentation #191

merged 2 commits into from Nov 22, 2021

Conversation

darkgl0w
Copy link
Member

@darkgl0w darkgl0w commented Nov 19, 2021

Hello.

  • Fixes tests by generating an ES256 (used curve: prime256v1) key pair, using a secp256k1 curve generates an ES256K key pair (currently not supported by jsonwebtoken or fast-jwt in the upcoming release).
  • Updates the related documentation.

For reference: rfc8812 - section 3.2.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

cc @simoneb

@simoneb
Copy link
Contributor

simoneb commented Nov 19, 2021

/cc @radomird

@radomird
Copy link
Contributor

Yes, looks good to me too. Thanks.

@darkgl0w
Copy link
Member Author

Right now new key pairs are automatically generated by the helper each time the tests will be run ^^

@radomird
Copy link
Contributor

Right now new key pairs are automatically generated by the helper each time the tests will be run ^^

Yes, true - I've deleted the question after realising that we do that. We don't do that in fast-jwt (that is why i was confused for a bit there). In fast-jwt we have pre-generated keys.

@mcollina mcollina merged commit 84b7936 into fastify:master Nov 22, 2021
@darkgl0w darkgl0w deleted the fix-crypto-key-gen branch November 22, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants