Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mongodb@5 #212

Merged
merged 1 commit into from
Mar 26, 2023
Merged

feat: mongodb@5 #212

merged 1 commit into from
Mar 26, 2023

Conversation

climba03003
Copy link
Member

Fixes #208
Closes #210 #205

Refactor on test case.
I use the addAssert function of tap to reduce the number of counts for plan.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003 climba03003 merged commit 659c752 into master Mar 26, 2023
@Fdawgs Fdawgs deleted the mongodb-5 branch March 26, 2023 09:49
@pip77
Copy link
Contributor

pip77 commented Mar 29, 2023

updating docs as I spent some time finding out that the docs are deprecated and callbacks are not supported with mongodb 5 #213

@climba03003
Copy link
Member Author

updating docs as I spent some time finding out that the docs are deprecated and callbacks are not supported with mongodb 5

It is why I bump a major to illustrate breaking changes.

pip77 added a commit to pip77/fastify that referenced this pull request Mar 29, 2023
As `@fastify/mongodb` updated to mongodb 5, callbacks are not supported anymore and we need to switch to promises
fastify/fastify-mongodb#212
jsumners pushed a commit to fastify/fastify that referenced this pull request Mar 29, 2023
As `@fastify/mongodb` updated to mongodb 5, callbacks are not supported anymore and we need to switch to promises
fastify/fastify-mongodb#212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MongoDB v5
3 participants