Avoid piping the same file multiple times in case saveRequestFile
is called twice.
#444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where multiple hooks and the handler needs to use the saved request files, and they cannot share the first call's result of
saveRequestFile
, they would call it twice or more which would result into piping the same file to disk more than once. As we can check by the following code:Now,
saveRequestFiles
will use the same system file and do not write the disk more than needed.Checklist
npm run test
andnpm run benchmark
and the Code of conduct