Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better error message for FST_REQ_FILE_TOO_LARGE #446

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

erfanium
Copy link
Contributor

@erfanium erfanium commented Jun 6, 2023

I think the please check multipart config part is extra to be in response body.
that's a 4xx error, so we should assume the client is wrong.

Checklist

@erfanium
Copy link
Contributor Author

@Uzlopak can you re-run the workflow? i'm sure something is wrong with ci

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@is2ei
Copy link
Contributor

is2ei commented Jun 18, 2023

I re-run the workflow and it still fails.
I investigated why it fails.
It seems lockfile version 3 causes some issues on Windows + Node.js v14.
tapjs/tapjs#843 (comment)

node-tap has changed the lockfile version in v16.3.5.
tapjs/tapjs@v16.3.4...v16.3.5

I created minimum example:
https://github.com/is2ei/_tap_16_0_0_windows/actions

@mcollina mcollina merged commit 0c4772a into fastify:master Jun 18, 2023
15 of 16 checks passed
@renovate renovate bot mentioned this pull request Jul 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants