Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty body handling when attachFieldsToBody is keyValues #450

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: Empty body handling when attachFieldsToBody is keyValues #450

merged 1 commit into from
Jul 17, 2023

Conversation

qqilihq
Copy link
Contributor

@qqilihq qqilihq commented Jun 23, 2023

We encountered 500 errors when attachFieldsToBody is set to keyValues and an empty body is submitted.

  • There's already a test case which covers this scenario for attachFieldsToBody set to true
  • Fixing this for attachFieldsToBody set to keyValues as well, and extend existing test

test/big.test.js fails for me locally, but it was failing before my changes already.

Checklist

mcollina
mcollina approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e7102b3 into fastify:master Jul 17, 2023
15 checks passed
@renovate renovate bot mentioned this pull request Jul 25, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qqilihq @mcollina