Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unorganized test structure #62

Closed
Ethan-Arrowood opened this issue Feb 4, 2019 · 1 comment
Closed

Fix unorganized test structure #62

Ethan-Arrowood opened this issue Feb 4, 2019 · 1 comment

Comments

@Ethan-Arrowood
Copy link
Member

I was reviewing this repo recently and noticed the unit-tests are unorganized. There is a root level types.test.ts file and then within the tests/ directory there are normal .js and .ts files. I'm going to take a stab at cleaning this up and additionally expose any missing typings or what not.
@Ethan-Arrowood Ethan-Arrowood mentioned this issue Feb 4, 2019
Merged
@fox1t
Copy link
Member

fox1t commented Aug 10, 2020

This issue was resolved by 63 and others.

@fox1t fox1t closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fox1t @Ethan-Arrowood